Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Topology/PartialHomeomorph): minor clean-up #9633

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - chore(Topology/PartialHomeomorph): minor clean-up #9633

wants to merge 11 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 10, 2024 •
edited by Parcly-Taxel
Loading

  • group related results into sections
  • move one section up, to a more logical place

Best reviewed commit by commit; the third commit is purely code motion. (Using the colorMoved option makes this obvious. Unfortunately, that's not available in the Github UI.)

@grunweg grunweg added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jan 10, 2024
@grunweg grunweg mentioned this pull request Jan 10, 2024
Closed
2 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 11, 2024
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jan 16, 2024
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 16, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2024
j-loreaux
j-loreaux reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just minor quibbles.

After fixing the issues below, please wait for CI to finish before merging.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 19, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Jan 19, 2024

Green (except for lean4checker, which should pass). Thanks for the review!
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 19, 2024
@grunweg
chore(Topology/PartialHomeomorph): minor clean-up (#9633)
eb34a25 
- group related results into sections
- move one section up, to a more logical place
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology/PartialHomeomorph): minor clean-up [Merged by Bors] - chore(Topology/PartialHomeomorph): minor clean-up Jan 20, 2024
@mathlib-bors mathlib-bors bot closed this Jan 20, 2024
@mathlib-bors mathlib-bors bot deleted the MR-topology.partialhomeo-cleanup branch January 20, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-loreaux j-loreaux j-loreaux left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grunweg @j-loreaux @sgouezel @leanprover-community-mathlib4-bot