[Merged by Bors] - chore: adaptations for leanprover/lean4#2923 #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Dec 13, 2023
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Dec 13, 2023
eric-wieser
reviewed
Dec 13, 2023
Co-authored-by: Eric Wieser <[email protected]>
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
This PR is targeting the `bump/v4.5.0` branch. It contains the adaptations required for leanprover/lean4#2923, which have now landed in the `2023-12-12` nightly toolchain. The only changes are in `simp [...] says ...` statements, where some spurious lemmas are now no longer reported. *Many* further `simp only` statements in Mathlib contain spurious lemmas which would now no longer be produced by a fresh `simp?`, and I would strongly encourage anyone interested in removing these! For now such changes will need to be made in a PR targeting `bump/v4.5.0` (like this PR), or in January they can be done on `master`. Co-authored-by: Scott Morrison <[email protected]>
eric-wieser
reviewed
Dec 14, 2023
| example [AddCommGroup α] (x y z : α) (_w : x = y + z) : x - x = 0 := by | ||
| abel_nf at * |
|
Pull request successfully merged into bump/v4.5.0. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
…h. (#9188) This PR: * bumps to lean-toolchain to `v4.5.0-rc1` * bumps the Std and Aesop dependencies to their versions using `v4.5.0-rc1` * merge the already reviewed changes from the `bump/v4.5.0` branch * adaptations for leanprover/lean4#2923 in #9011 * adaptations for leanprover/lean4#2973 in #9161 * adaptations for leanprover/lean4#2964 in #9176 Co-authored-by: Scott Morrison <[email protected]> Co-authored-by: Eric Wieser <[email protected]>
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is targeting the
bump/v4.5.0branch. It contains the adaptations required for leanprover/lean4#2923, which have now landed in the2023-12-12nightly toolchain.The only changes are in
simp [...] says ...statements, where some spurious lemmas are now no longer reported.Many further
simp onlystatements in Mathlib contain spurious lemmas which would now no longer be produced by a freshsimp?, and I would strongly encourage anyone interested in removing these! For now such changes will need to be made in a PR targetingbump/v4.5.0(like this PR), or in January they can be done onmaster.