[Merged by Bors] - Update docstring of squeeze_one_norm'
#8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`squeeze_one_norm'` and `squeeze_zero_norm'` had the same docstring. The docstring of `squeeze_one_norm'` was strictly speaking incorrect (writing `0` instead of `1`). The docstring of `squeeze_one_norm'` is correct but perhaps this change makes it less likely to be misunderstood by people missing what `E` is.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adomasbaliuka
added
easy
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
`squeeze_one_norm'` and `squeeze_zero_norm'` had the same docstring. The docstring of `squeeze_zero_norm'` was strictly speaking incorrect (writing `1` instead of `0`). The docstring of `squeeze_one_norm'` was correct but perhaps this change makes it easier for people to notice the difference and what `E` is.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
squeeze_one_norm'squeeze_one_norm'
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
`squeeze_one_norm'` and `squeeze_zero_norm'` had the same docstring. The docstring of `squeeze_zero_norm'` was strictly speaking incorrect (writing `1` instead of `0`). The docstring of `squeeze_one_norm'` was correct but perhaps this change makes it easier for people to notice the difference and what `E` is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squeeze_one_norm'andsqueeze_zero_norm'had the same docstring. The docstring ofsqueeze_zero_norm'was strictly speaking incorrect (writing1instead of0).The docstring of
squeeze_one_norm'was correct but perhaps this change makes it easier for people to notice the difference and whatEis.