[Merged by Bors] - chore: build ProofWidgets before tests #8416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
awaiting-review
easy
|
Why is this needed if we have already downloaded a release containing all the .oleans? |
Because those oleans will have been compiled with the Previously we were just using them anyway. leanprover/lean4#2766 will start rejecting them instead. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
After leanprover/lean4#2766 this becomes critical. Co-authored-by: Scott Morrison <[email protected]>
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
After leanprover/lean4#2766 this becomes critical. Co-authored-by: Scott Morrison <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
After leanprover/lean4#2766 this becomes critical. Co-authored-by: Scott Morrison <[email protected]>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
After leanprover/lean4#2766 this becomes critical. Co-authored-by: Scott Morrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After leanprover/lean4#2766 this becomes critical.