Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: patch for std4#193 #6188

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: patch for std4#193 #6188

wants to merge 1 commit into from

Conversation

fgdorais
Copy link
Collaborator

@fgdorais fgdorais commented Jul 27, 2023 •
edited
Loading

fix: patch for std4#193

This was just merged into Std. The Mathlib patch is very small.

Open in Gitpod

@fgdorais fgdorais added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) blocked-by-batt-PR This PR depends on a PR to Batteries WIP Work in progress labels Jul 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 27, 2023
@fgdorais fgdorais mentioned this pull request Jul 27, 2023
Merged
1 task
@fgdorais fgdorais added the t-algebra Algebra (groups, rings, fields, etc) label Jul 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 28, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 28, 2023
@kim-em kim-em mentioned this pull request Aug 3, 2023
Closed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 7, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Aug 15, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@fgdorais fgdorais requested review from kim-em and eric-wieser August 16, 2023 01:23
@fgdorais fgdorais removed WIP Work in progress blocked-by-batt-PR This PR depends on a PR to Batteries labels Aug 16, 2023
@fgdorais
Copy link
Collaborator Author

Having some Lake pains. I might need to fix this tomorrow. Sorry, this was supposed to be quick and easy!

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI labels Aug 16, 2023
@kim-em kim-em removed their request for review August 16, 2023 04:25
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 16, 2023
@fgdorais
Copy link
Collaborator Author

All fixed now!

@fgdorais fgdorais removed the awaiting-author A reviewer has asked the author a question or requested changes label Aug 17, 2023
@fgdorais fgdorais mentioned this pull request Aug 17, 2023
Closed
2 tasks
@kim-em
Copy link
Contributor

kim-em commented Aug 17, 2023

bors p=10

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Aug 17, 2023
bors bot pushed a commit that referenced this pull request Aug 17, 2023
@fgdorais
fix: patch for std4#193 (#6188)
5f5c4e1 
fix: patch for std4#193
@bors
Copy link

bors bot commented Aug 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: patch for std4#193 [Merged by Bors] - fix: patch for std4#193 Aug 17, 2023
@bors bors bot closed this Aug 17, 2023
@bors bors bot deleted the fgdorais-nat-rec branch August 17, 2023 11:16
@kim-em kim-em mentioned this pull request Aug 17, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgdorais @leanprover-community-mathlib4-bot @kim-em