Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port MeasureTheory.Function.ConvergenceInMeasure #4484

Closed

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 30, 2023


todo:

  • TendstoInMeasure.exists_seq_tendsto_ae errors with number types and ^

Open in Gitpod

int-y1 added 4 commits May 29, 2023 16:21
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 30, 2023
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels May 30, 2023
@xroblot
Copy link
Collaborator

xroblot commented May 31, 2023

This one is a bit more tricky. There is currently a bug in Mathlib4 so that terms like r ^ n with r : ℝ and n : ℕ are changed automatically to r ^ (n : ℝ), see this issue

The way to fix that (at the moment) is to add the line

local macro_rules | `($x ^ $y)   => `(HPow.hPow $x $y)

but then in any power of the form a ^ n with a : ℕ and n a negative integer fails because Lean does not to which type to cast a thus you need to give it the cast explicitly, say (a : ℝ) ^ n. In some cases, the correct type is not . In this file, it is ℝ≥0∞ at some places. You need to look at what happens in Lean3 for this file to figure out the correct type to use.

@int-y1 int-y1 added awaiting-review and removed help-wanted The author needs attention to resolve issues labels Jun 1, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 1, 2023
bors bot pushed a commit that referenced this pull request Jun 1, 2023
Co-authored-by: Xavier-François Roblot <[email protected]>
Co-authored-by: Parcly Taxel <[email protected]>
@bors
Copy link

bors bot commented Jun 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port MeasureTheory.Function.ConvergenceInMeasure [Merged by Bors] - feat: port MeasureTheory.Function.ConvergenceInMeasure Jun 1, 2023
@bors bors bot closed this Jun 1, 2023
@bors bors bot deleted the port/MeasureTheory.Function.ConvergenceInMeasure branch June 1, 2023 13:13
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants