Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(List/Perm): add lemmas #22288

Closed
wants to merge 3 commits into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 25, 2025

  • Add List.map_perm_map_iff and List.Perm.flatMap.
  • Add some @[gcongr] and @[simp] attrs.
  • Add Relation.comp_fun_eq and Relation.fun_eq_comp.

Open in Gitpod

- Add `List.map_perm_map_iff` and `List.Perm.flatMap`.
- Add some `@[gcongr]` and `@[simp]` attrs.
- Add `Relation.comp_fun_eq` and `Relation.fun_eq_comp`.
Copy link

github-actions bot commented Feb 25, 2025

PR summary 4b38037fe8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Perm.flatMap
+ comp_eq_fun
+ eq_map_comp_perm
+ fun_eq_comp
+ map_perm_map_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 25, 2025

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Feb 26, 2025
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 26, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 26, 2025
- Add `List.map_perm_map_iff` and `List.Perm.flatMap`.
- Add some `@[gcongr]` and `@[simp]` attrs.
- Add `Relation.comp_fun_eq` and `Relation.fun_eq_comp`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 26, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(List/Perm): add lemmas [Merged by Bors] - feat(List/Perm): add lemmas Feb 26, 2025
@mathlib-bors mathlib-bors bot closed this Feb 26, 2025
@mathlib-bors mathlib-bors bot deleted the YK-list-perm branch February 26, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants