Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Set): lemmas about set difference #22253

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

apnelson1
Copy link
Collaborator

@apnelson1 apnelson1 commented Feb 24, 2025

We add some API lemmas about set difference and strict subsets.


Open in Gitpod

Copy link

github-actions bot commented Feb 24, 2025

PR summary e12a8f1d46

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.HasSubset.Subset.diff_ssubset_of_nonempty
+ _root_.HasSubset.Subset.ssubset_of_mem_not_mem
+ diff_inter_distrib_right
+ diff_inter_right_comm
+ diff_ssubset_left_iff
+ diff_union_diff_cancel_of_inter_subset_of_subset_union
+ insert_diff_insert
+ inter_diff_right_comm
+ inter_ssubset_left_iff
+ inter_ssubset_right_iff
+ sdiff_lt_left
+ ssubset_union_left_iff
+ ssubset_union_right_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Feb 24, 2025
@vihdzp
Copy link
Collaborator

vihdzp commented Feb 25, 2025

Out of curiosity, can any of these be proven by the new tauto_set tactic?

@apnelson1
Copy link
Collaborator Author

apnelson1 commented Feb 25, 2025

Out of curiosity, can any of these be proven by the new tauto_set tactic?

The distributivity ones surely can (though I haven't checked). It doesn't handle nonequality yet, so the ssubset ones can't.

It's too early in the API to actually use the tactic in their proofs, though.

I am already a keen user of the tactic, but I still think these lemmas would be good to have - they are mostly the kind of lemma where rw [show _ by tauto_set] is more cumbersome to write in practice than just rw [lemma_name].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants