Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/Category): clean up erw and porting notes #22249

Closed
wants to merge 3 commits into from

Conversation

Vierkantor
Copy link
Contributor

I searched for erw and porting note and did my best to fix them. We still have lots of ugly erws in (presheaves of) ModuleCat, unfortunately...


Open in Gitpod

I searched for `erw` and `porting note` and did my best to fix them. We still have lots of ugly `erw`s in (presheaves of) `ModuleCat`, unfortunately...
@Vierkantor Vierkantor added t-category-theory Category theory t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Feb 24, 2025
Copy link

github-actions bot commented Feb 24, 2025

PR summary efcf3d9e50

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ RingHom.smul_toAlgebra
- instance (G : Grp) : Group G.carrier

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (9.76, 0.01)
Current number Change Type
3322 -27 porting notes
1303 -3 erw

Current commit efcf3d9e50
Reference commit f410b48e6f

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Co-authored-by: damiano <[email protected]>
Copy link
Collaborator

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

I'll let someone else actually merge the PR, since I do not know too well category theory in mathlib.

@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 24, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 24, 2025
I searched for `erw` and `porting note` and did my best to fix them. We still have lots of ugly `erw`s in (presheaves of) `ModuleCat`, unfortunately...




Co-authored-by: Anne Baanen <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 24, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra/Category): clean up erw and porting notes [Merged by Bors] - chore(Algebra/Category): clean up erw and porting notes Feb 24, 2025
@mathlib-bors mathlib-bors bot closed this Feb 24, 2025
@mathlib-bors mathlib-bors bot deleted the Vierkantor/category-cleanup-1 branch February 24, 2025 18:44
Champitoad pushed a commit that referenced this pull request Feb 25, 2025
I searched for `erw` and `porting note` and did my best to fix them. We still have lots of ugly `erw`s in (presheaves of) `ModuleCat`, unfortunately...




Co-authored-by: Anne Baanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants