-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Algebra/Category): clean up erw
and porting notes
#22249
Conversation
I searched for `erw` and `porting note` and did my best to fix them. We still have lots of ugly `erw`s in (presheaves of) `ModuleCat`, unfortunately...
PR summary efcf3d9e50Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for Decrease in tech debt: (relative, absolute) = (9.76, 0.01)
Current commit efcf3d9e50 You can run this locally as
|
Co-authored-by: damiano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
I'll let someone else actually merge the PR, since I do not know too well category theory in mathlib.
Thanks! bors merge |
I searched for `erw` and `porting note` and did my best to fix them. We still have lots of ugly `erw`s in (presheaves of) `ModuleCat`, unfortunately... Co-authored-by: Anne Baanen <[email protected]>
Pull request successfully merged into master. Build succeeded: |
erw
and porting noteserw
and porting notes
I searched for `erw` and `porting note` and did my best to fix them. We still have lots of ugly `erw`s in (presheaves of) `ModuleCat`, unfortunately... Co-authored-by: Anne Baanen <[email protected]>
I searched for
erw
andporting note
and did my best to fix them. We still have lots of uglyerw
s in (presheaves of)ModuleCat
, unfortunately...