Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Order/KrullDimension): some lemmas relating Order.height, Order.coheight and krullDim #22236

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xyzw12345
Copy link
Collaborator

This PR mostly consists of the lemmas related to Order.height, Order.coheight, and krullDim appearing in the process of working on PR #21041. We thought that the lemmas may be useful to other PRs (like #22127 perhaps?), so we decided to open it into a separate PR to accelerate the review process.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 24, 2025
Copy link

github-actions bot commented Feb 24, 2025

PR summary 0805b2467c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Order.KrullDimension 635 638 +3 (+0.47%)
Import changes for all files
Files Import difference
Mathlib.Order.KrullDimension 3

Declarations diff

+ coheight_eq_krullDim_Ici
+ finiteDimensionalOrder_iff_krullDim_ne_bot_and_top
+ height_eq_krullDim_Iic
+ krullDim_isSimpleOrder
+ nonempty_of_finiteDimensional
+ nonempty_of_finiteDimensionalType

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-order Order theory label Feb 24, 2025
@xyzw12345 xyzw12345 added easy < 20s of review time. See the lifecycle page for guidelines. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants