-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Order/KrullDimension): some lemmas relating Order.height
, Order.coheight
and krullDim
#22236
Open
xyzw12345
wants to merge
6
commits into
master
Choose a base branch
from
xyzw12345_Order_lemmas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 0805b2467c
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Order.KrullDimension | 635 | 638 | +3 (+0.47%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.Order.KrullDimension |
3 |
Declarations diff
+ coheight_eq_krullDim_Ici
+ finiteDimensionalOrder_iff_krullDim_ne_bot_and_top
+ height_eq_krullDim_Iic
+ krullDim_isSimpleOrder
+ nonempty_of_finiteDimensional
+ nonempty_of_finiteDimensionalType
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
2 tasks
riccardobrasca
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new-contributor
This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!
t-order
Order theory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly consists of the lemmas related to
Order.height
,Order.coheight
, andkrullDim
appearing in the process of working on PR #21041. We thought that the lemmas may be useful to other PRs (like #22127 perhaps?), so we decided to open it into a separate PR to accelerate the review process.