Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RepresentationTheory): generalize most of FDRep to commutative rings #22235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcommelin
Copy link
Member


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 24, 2025
Copy link

PR summary bcff648f44

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance (V : FDRep R G) : AddCommGroup V := by
+ instance (V : FDRep R G) : Module R V := by
+ instance (V : FDRep R G) : Module.Finite R V := by
+ instance : CoeSort (FDRep R G) (Type u)
+ instance : ConcreteCategory (FDRep R G) (Action.HomSubtype _ _) := inferInstance
+ instance : HasForget₂ (FDRep R G) (Rep R G)
+ instance : LargeCategory (FDRep R G) := inferInstance
+ instance : Linear R (FDRep R G) := by infer_instance
+ instance : Preadditive (FDRep R G) := inferInstance
- instance (V : FDRep k G) : AddCommGroup V := by
- instance (V : FDRep k G) : Module k V := by
- instance : CoeSort (FDRep k G) (Type u)
- instance : ConcreteCategory (FDRep k G) (Action.HomSubtype _ _) := inferInstance
- instance : HasForget₂ (FDRep k G) (Rep k G)
- instance : LargeCategory (FDRep k G) := inferInstance
- instance : Linear k (FDRep k G) := by infer_instance
- instance : Preadditive (FDRep k G) := inferInstance

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@@ -45,85 +45,88 @@ open CategoryTheory.Limits


/-- The category of finite dimensional `k`-linear representations of a monoid `G`. -/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/-- The category of finite dimensional `k`-linear representations of a monoid `G`. -/
/-- The category of finite dimensional `R`-linear representations of a monoid `G`. -/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pointed out that line but there's similarly some ks that should be Rs on lines 83 and 144. I'm not sure about the doc string at the beginning of the file, since the case where R is a field is the most important case.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants