-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(RepresentationTheory): generalize most of FDRep to commutative rings #22235
base: master
Are you sure you want to change the base?
Conversation
jcommelin
commented
Feb 24, 2025
PR summary bcff648f44Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
@@ -45,85 +45,88 @@ open CategoryTheory.Limits | |||
|
|||
|
|||
/-- The category of finite dimensional `k`-linear representations of a monoid `G`. -/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/-- The category of finite dimensional `k`-linear representations of a monoid `G`. -/ | |
/-- The category of finite dimensional `R`-linear representations of a monoid `G`. -/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pointed out that line but there's similarly some k
s that should be R
s on lines 83 and 144. I'm not sure about the doc string at the beginning of the file, since the case where R
is a field is the most important case.