Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc(Tactic/Ring/Basic): fix documentation for ExProd.mkRat #22180

Closed
wants to merge 2 commits into from

Conversation

Command-Master
Copy link
Collaborator


Open in Gitpod

@Command-Master Command-Master added documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 22, 2025
Copy link

github-actions bot commented Feb 22, 2025

PR summary 1a96a5c19e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@joneugster joneugster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by joneugster.

@adomani
Copy link
Collaborator

adomani commented Feb 25, 2025

Thanks! I also like Jon's suggestion, but think that it is optional.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 25, 2025

✌️ Command-Master can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Command-Master
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 25, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 25, 2025

Build failed:

@bryangingechen
Copy link
Contributor

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 25, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 25, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 25, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(Tactic/Ring/Basic): fix documentation for ExProd.mkRat [Merged by Bors] - doc(Tactic/Ring/Basic): fix documentation for ExProd.mkRat Feb 25, 2025
@mathlib-bors mathlib-bors bot closed this Feb 25, 2025
@mathlib-bors mathlib-bors bot deleted the CM_ringtacdocfix branch February 25, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants