Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: fix naming oversight from #22070 #22128

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore: fix naming oversight from #22070 #22128

wants to merge 5 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Feb 20, 2025

Per zulip discussion: these were merged a few hours ago, hence need no deprecations yet.

Open in Gitpod

@grunweg grunweg added the easy < 20s of review time. See the lifecycle page for guidelines. label Feb 20, 2025
@grunweg grunweg requested a review from ADedecker February 20, 2025 14:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

PR summary 0e8b126c40

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Continuous.sumElim
+ IsClosedEmbedding.sumElim
+ IsClosedMap.sumElim
+ IsOpenEmbedding.sumElim
+ IsOpenMap.sumElim
+ continuous_sumElim
+ isClosedMap_sumElim
+ isOpenMap_sumElim
- IsClosedEmbedding.sum_elim
- IsClosedMap.sum_elim
- IsOpenEmbedding.sum_elim
- isClosedMap_sum_elim

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Feb 20, 2025
@ADedecker
Copy link
Member

Could you also fix the existing names for isOpenMap_sum_elim and IsOpenMap.sum_elim (and add the relevant deprecations for these)? Thanks!

@fpvandoorn
Copy link
Member

LGTM

bors d+

Function.Injective.sum_elim and friends would probably also like to be changed (in a different PR).

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2025

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Feb 20, 2025 •
edited
Loading

Done, and I added the ContMDiff lemmas also since they were a recent change of mine. Split into a separate PR.
All similar work will happen in follow-up PRs.

@grunweg grunweg mentioned this pull request Feb 20, 2025
Closed
@grunweg grunweg mentioned this pull request Feb 20, 2025
Open
7 tasks
@grunweg
Copy link
Collaborator Author

grunweg commented Feb 20, 2025

CI is green: everything builds and tests pass; this should not have any linting-relevant effect.
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2025
@grunweg
chore: fix naming oversight from #22070 (#22128)
b2b26f1 
Per [zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/.7BIsInducing.2CIsEmbedding.7D.2Esum_elim/near/500877183): these were merged a few hours ago, hence need no deprecations yet.
@grunweg grunweg mentioned this pull request Feb 20, 2025
Open
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix naming oversight from #22070 [Merged by Bors] - chore: fix naming oversight from #22070 Feb 20, 2025
@mathlib-bors mathlib-bors bot closed this Feb 20, 2025
@mathlib-bors mathlib-bors bot deleted the MR-rename-sumelim branch February 20, 2025 19:11
@grunweg grunweg mentioned this pull request Feb 21, 2025
Closed
mathlib-bors bot pushed a commit that referenced this pull request Feb 21, 2025
@grunweg
chore: rename {Continuous., continuous_}sum_map to sumMap (#22155)
f8a3148 
To match the naming convention, successor of #22128.
Julian added a commit that referenced this pull request Feb 21, 2025
@Julian
Merge remote-tracking branch 'origin/master' into polynomial-sequences
05a9447 
* origin/master: (823 commits)
  chore(Computability): fix naming of lemmas about Sum.inl, Sum.inr, Sum.casesOn (#22156)
  feat: `Fintype Ordering` (#22154)
  chore: more renamings to fit the naming convention (#22148)
  feat(CategoryTheory): any monomorphism in a Grothendieck abelian category is a transfinite composition of pushouts of monomorphisms in a small family (#22157)
  chore: rename `{Continuous., continuous_}sum_map` to `sumMap` (#22155)
  chore: remove initial space followed by `-/` (#22158)
  chore: make arg in HeightOneSpectrum.valuation explicit (#22139)
  feat(Data/List): `List.maximum` is monotone (#22091)
  chore(Combinatorics/SimpleGraph): extract WalkDecomp from Walk (#21981)
  feat: if a monoid M acts, then so does (s : S) with [SubmonoidClass S M] (#21123)
  chore: backport changes to `getElem` lemmas (#22146)
  feat(CategoryTheory): generating monomorphisms in Grothendieck abelian categories (#22150)
  feat: rename variables to fit doc (#22143)
  feat(CategoryTheory): IsDetecting.isIso_iff_of_mono (#22135)
  feat(CategoryTheory): truncations of transfinite compositions (#22149)
  chore: simplify a proof (#22134)
  feat(CategoryTheory): monomorphisms are stable under coproducts in Grothendieck abelian categories (#22133)
  feat(Order): Set.Ici.isSuccLimit_coe (#22103)
  chore(Analysis/Convex/Normed): split into smaller files (#22015)
  feat(Algebra/Algebra/Lie): max nilpotent ideal <= radical (#22140)
  refactor(LinearIndependent): refactor to use LinearIndepOn (#21886)
  chore: rename some more `Foo.sum_elim` -> `sumElim` (#22130)
  chore: rename Injective.sum_elim and friends (#22129)
  chore: fix naming oversight from #22070 (#22128)
  chore: fix spelling mistakes (#22136)
  feat(RingTheory/Ideal/Quotient): define transtition map between ring or module quotient by powers of ideal (#21900)
  fix: initialize_simps_projections print warning when projection data already exists (#20339)
  chore: rename ContMDiff.sum_{elim,map} (#22131)
  feat(CategoryTheory): characterization of injective objects in terms of lifting properties (#22104)
  chore(Lean,Tactic): un-indent some doc-strings (#22118)
  feat(Algebra/MvPolynomial): add `comp` versions of rename lemmas (#21259)
  chose: add deprecation (#22124)
  feat(CategoryTheory/Abelian/GrothendieckCategory): computing colimits in Subobject (#22123)
  feat(CategoryTheory/Subobject): hasCardinalLT_of_mono (#22122)
  feat: add `DenseRange.piMap` (#22114)
  feat(Algebra/Algebra/Lie): define the maximal nilpotent ideal of Lie algebras (#22061)
  chore(Data/Finset): don't import algebra when defining `Finset.card` (#21866)
  feat: a function on a discrete space is smooth (#22113)
  feat: commutative group objects in additive categories (#21521)
  style(Geometry/Manifold): remove superfluous indentation in doc-strings (#22117)
  chore: rename PushNeg.lean to Push.lean (#22108)
  feat: add Is{Open,Closed}Embedding.sum_elim (#22070)
  feat(RingTheory/Perfectoid): define the untilt map and generalize pretilt (#21563)
  feature(Topology/Algebra/Module/WeakBilin): Linear map from F into the topological dual of E with the weak topology (#21078)
  feat(CategoryTheory/Abelian): the exact sequence attached to a pushout square (#22110)
  chore(ChartedSpace.lean): group constructions together (#22107)
  feat(CategoryTheory/MorphismProperty): more basic API (#22099)
  chore(Data/Fintype): split `Fintype/Card.lean` (#21840)
  chore(SetTheory/Cardinal/Cofinality): make `IsStrongLimit` into a structure (#21971)
  feat(Combinatorics/SimpleGraph): Add a theorem about cliques in induced subgraphs (#20705)
  ...
Julian added a commit that referenced this pull request Feb 22, 2025
@Julian
Merge branch 'polynomial-sequences' into bhargava-factorial
1155d39 
* polynomial-sequences: (558 commits)
  Correct the TODO to mention IsCancelAdd which does exist.
  Talk about strict monotonicity instead, thanks @pechersky.
  Mention the TODO on li generalization to semirings.
  One more dedent.
  Same injectivity twiddling for basis.
  nontiviality to simplify this proof, and some dedenting.
  Hopefully more correct injectivity lemmas matching the naming convention.
  Fix the empty docstring.
  Update Mathlib/Algebra/Polynomial/Sequence.lean
  Fix the variable naming.
  Apply suggestions from code review
  chore(Computability): fix naming of lemmas about Sum.inl, Sum.inr, Sum.casesOn (#22156)
  feat: `Fintype Ordering` (#22154)
  chore: more renamings to fit the naming convention (#22148)
  feat(CategoryTheory): any monomorphism in a Grothendieck abelian category is a transfinite composition of pushouts of monomorphisms in a small family (#22157)
  chore: rename `{Continuous., continuous_}sum_map` to `sumMap` (#22155)
  chore: remove initial space followed by `-/` (#22158)
  chore: make arg in HeightOneSpectrum.valuation explicit (#22139)
  feat(Data/List): `List.maximum` is monotone (#22091)
  chore(Combinatorics/SimpleGraph): extract WalkDecomp from Walk (#21981)
  feat: if a monoid M acts, then so does (s : S) with [SubmonoidClass S M] (#21123)
  chore: backport changes to `getElem` lemmas (#22146)
  feat(CategoryTheory): generating monomorphisms in Grothendieck abelian categories (#22150)
  feat: rename variables to fit doc (#22143)
  feat(CategoryTheory): IsDetecting.isIso_iff_of_mono (#22135)
  feat(CategoryTheory): truncations of transfinite compositions (#22149)
  chore: simplify a proof (#22134)
  feat(CategoryTheory): monomorphisms are stable under coproducts in Grothendieck abelian categories (#22133)
  feat(Order): Set.Ici.isSuccLimit_coe (#22103)
  chore(Analysis/Convex/Normed): split into smaller files (#22015)
  feat(Algebra/Algebra/Lie): max nilpotent ideal <= radical (#22140)
  refactor(LinearIndependent): refactor to use LinearIndepOn (#21886)
  chore: rename some more `Foo.sum_elim` -> `sumElim` (#22130)
  chore: rename Injective.sum_elim and friends (#22129)
  chore: fix naming oversight from #22070 (#22128)
  chore: fix spelling mistakes (#22136)
  feat(RingTheory/Ideal/Quotient): define transtition map between ring or module quotient by powers of ideal (#21900)
  fix: initialize_simps_projections print warning when projection data already exists (#20339)
  chore: rename ContMDiff.sum_{elim,map} (#22131)
  feat(CategoryTheory): characterization of injective objects in terms of lifting properties (#22104)
  chore(Lean,Tactic): un-indent some doc-strings (#22118)
  feat(Algebra/MvPolynomial): add `comp` versions of rename lemmas (#21259)
  chose: add deprecation (#22124)
  feat(CategoryTheory/Abelian/GrothendieckCategory): computing colimits in Subobject (#22123)
  feat(CategoryTheory/Subobject): hasCardinalLT_of_mono (#22122)
  feat: add `DenseRange.piMap` (#22114)
  feat(Algebra/Algebra/Lie): define the maximal nilpotent ideal of Lie algebras (#22061)
  chore(Data/Finset): don't import algebra when defining `Finset.card` (#21866)
  feat: a function on a discrete space is smooth (#22113)
  feat: commutative group objects in additive categories (#21521)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADedecker ADedecker Awaiting requested review from ADedecker

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grunweg @ADedecker @fpvandoorn @leanprover-community-mathlib4-bot