Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RingTheory/Localization/Pi): localization of a finite direct product where each semiring in product has maximal nilradical is a projection #22018

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

maddycrim
Copy link
Collaborator

For noncomputable def urjectivePiNilradicalIsMaximal : Let M be a submonoid of a direct product of commutative rings R i.
If each R i has maximal nilradical then the direct product ∏ R i surjects onto the
localization of ∏ R i at M.


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! large-import Automatically added label for PRs with a significant increase in transitive imports labels Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

PR summary 5b97412114

Import changes exceeding 2%

% File
+32.80% Mathlib.RingTheory.Localization.Pi

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Localization.Pi 872 1158 +286 (+32.80%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Localization.Pi 286

Declarations diff

+ algebraMap_pi_surjective_of_nilradical_isMaximal
+ surjective_piRingHom_algebraMap_comp_piEvalRingHom_of_nilradical_isMaximal

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 18, 2025
@Paul-Lez Paul-Lez self-requested a review February 18, 2025 17:38
Comment on lines +100 to +101
refine ⟨r, Bijective.injective (bijective_lift_piRingHom_algebraMap_comp_piEvalRingHom R S _ M)
?_⟩
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(untested)

Suggested change
refine ⟨r, Bijective.injective (bijective_lift_piRingHom_algebraMap_comp_piEvalRingHom R S _ M)
?_⟩
refine ⟨r, (bijective_lift_piRingHom_algebraMap_comp_piEvalRingHom R S _ M).injective ?_⟩

If each `R i` has maximal nilradical then the direct product `∏ R i` surjects onto the
localization of `∏ R i` at `M`. -/
lemma algebraMap_pi_surjective_of_nilradical_isMaximal (h : ∀ i, (nilradical (R i)).IsMaximal)
[IsLocalization M S'] [Fintype ι] : Surjective (algebraMap (Π i, R i) (S')) := by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[IsLocalization M S'] [Fintype ι] : Surjective (algebraMap (Π i, R i) (S')) := by
[IsLocalization M S'] [Fintype ι] : Surjective (algebraMap (Π i, R i) S') := by

@Paul-Lez Paul-Lez requested a review from eric-wieser February 25, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants