Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Order): Trimmed length of a RelSeries #21869

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Raph-DG
Copy link
Collaborator

@Raph-DG Raph-DG commented Feb 14, 2025

In this PR, we define the trimmed length of a relseries rs : RelSeries (· ≤ ·) to be the cardinality of the underlying function rs.toFun of rs minus 1. This models the number of < relations occuring in rs. We develop some basic API for this notion, with the main intended application being a proof that module length is additive.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

PR summary 07d6cda80f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Order.TrimmedLength (new file) 579

Declarations diff

+ RelSeries.length_eq_trimmedLength_iff
+ RelSeries.trim
+ RelSeries.trimmedLength
+ RelSeries.trimmedLength_eraseLast_le
+ RelSeries.trimmedLength_eraseLast_of_eq
+ RelSeries.trimmedLength_eraseLast_of_lt
+ RelSeries.trimmedLength_exists_le
+ RelSeries.trimmedLength_le_length
+ instance (rs : RelSeries (α := α) (· ≤ ·)) :
+ rel_of_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-order Order theory label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants