Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(LightProfinite): remove unecessary have #21689

Closed
wants to merge 1 commit into from

Conversation

mattrobball
Copy link
Collaborator

The have can be synthesized and deleting it results in a term equivalent at reducible and instances transparency.


Open in Gitpod

Copy link

PR summary ca9b9ce4b2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Feb 10, 2025
@kim-em
Copy link
Contributor

kim-em commented Feb 11, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2025
The `have` can be synthesized and deleting it results in a term equivalent at reducible and instances transparency.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(LightProfinite): remove unecessary have [Merged by Bors] - chore(LightProfinite): remove unecessary have Feb 12, 2025
@mathlib-bors mathlib-bors bot closed this Feb 12, 2025
@mathlib-bors mathlib-bors bot deleted the mrb/remove_have_light_profinite_basic branch February 12, 2025 01:01
joneugster pushed a commit that referenced this pull request Feb 12, 2025
The `have` can be synthesized and deleting it results in a term equivalent at reducible and instances transparency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants