-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preimages of codiscrete sets under analytic function in one variable #21594
base: master
Are you sure you want to change the base?
Conversation
PR summary 528bc7c595
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Analysis.Analytic.IsolatedZeros | 1614 | 1616 | +2 (+0.12%) |
Import changes for all files
Files | Import difference |
---|---|
4 filesMathlib.Analysis.Analytic.IsolatedZeros Mathlib.Analysis.Analytic.Order Mathlib.Analysis.Meromorphic.Basic Mathlib.Analysis.Meromorphic.Order |
2 |
Declarations diff
+ AnalyticAt.map_nhdsNE
+ AnalyticAt.preimage_of_nhdsNE
+ AnalyticOnNhd.map_codiscreteWithin
+ AnalyticOnNhd.preimage_mem_codiscreteWithin
+ Filter.codiscreteWithin.mono
+ compl_diff
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
I am sorry; I don't understand the topic; I cannot review this PR. |
@madvorak Thanks for taking the time to look at my PR! |
You get better adn faster reviews if you add a topic label on the right, Stefan :) Moreover, here on the queueboard you can ensure your PR satisfies everything required to be on the review queue: https://jcommelin.github.io/queueboard/on_the_queue.html (although, it doesn't yet flag a missing topic label as potential slow-down) |
@joneugster Thanks for explaining the label. I was totally unaware of that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
I'm not really qualified to review analysis PRs, so take this with a grain of salt.
Co-authored-by: Jon Eugster <[email protected]>
Co-authored-by: Jon Eugster <[email protected]>
Co-authored-by: Jon Eugster <[email protected]>
Co-authored-by: Jon Eugster <[email protected]>
Co-authored-by: Jon Eugster <[email protected]>
Co-authored-by: Jon Eugster <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I just have a minor naming remark (I know how tedious these naming arguments are, sorry).
Best wishes, David
@joneugster @loefflerd Thank you for your time and help. I implemented all your suggestions. |
Establish corollary of the "principle of isolated zeros": for analytic functions in one variable, the preimage of a set that is codiscrete within the range is codiscrete within the domain.
This material is used in Project VD, which aims to formalize Value Distribution Theory for meromorphic functions on the complex plane. More precisely, it is used when replacing meromorphic functions by their continuous extension, and functions of the form
log |f*g|
bylog |f| + log |g|
. In both instances, the functions remain unchanged along codiscrete sets, which makes the change irrelevant for integration.