-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: avoid unnecessary change
tactics
#20486
base: master
Are you sure you want to change the base?
Conversation
Another one thanks to @dwrensha's |
PR summary 0644c2101aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for Decrease in tech debt: (relative, absolute) = (3.00, 0.00)
Current commit 0644c2101a You can run this locally as
|
change
tactics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainer merge
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
!bench |
Here are the benchmark results for commit 377edfc. |
I worry that dropping the |
@eric-wieser, do you see other |
change e t.2 / e t.1 = e (t.2 / t.1) | ||
rw [← map_div e t.2 t.1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one can probably just become exact (map_div e t.2 t.1).symm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But simp
is better, no?
the build is failing |
Sorry, looks like there's yet another merge conflict: bors d+ |
✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with |
change
is always a bit of smell, so in cases wheresimp
can just close the goal unassisted, do that.