Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Combinatorics/SimpleGraph): rename and add gcongr tag to distance lemmas #15780

Closed
wants to merge 2 commits into from

Conversation

Rida-Hamadani
Copy link
Collaborator


Open in Gitpod

Copy link

github-actions bot commented Aug 13, 2024

PR summary ac6beadadb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Reachable.dist_anti
+ edist_anti
- dist_le_subgraph_dist
- edist_le_subgraph_edist

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@Rida-Hamadani
Copy link
Collaborator Author

@YaelDillies is it a good idea to tag the dist lemma with gcongr too?

Co-authored-by: Yaël Dillies <[email protected]>
@Rida-Hamadani Rida-Hamadani added easy < 20s of review time. See the lifecycle page for guidelines. t-combinatorics Combinatorics labels Aug 13, 2024
@YaelDillies
Copy link
Collaborator

Let's go!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Aug 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 14, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Combinatorics/SimpleGraph): rename and add gcongr tag to distance lemmas [Merged by Bors] - chore(Combinatorics/SimpleGraph): rename and add gcongr tag to distance lemmas Aug 14, 2024
@mathlib-bors mathlib-bors bot closed this Aug 14, 2024
@mathlib-bors mathlib-bors bot deleted the rida/edistGcongr branch August 14, 2024 00:20
@Ruben-VandeVelde
Copy link
Collaborator

Deprecated aliases seem to be missing?

@Rida-Hamadani
Copy link
Collaborator Author

@Ruben-VandeVelde Sorry, these lemmas were added recently, and so far only used in an open PR by me which I will edit. Should we add deprecated aliases or is it okay if we leave it this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge ready-to-merge This PR has been sent to bors. t-combinatorics Combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants