Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: backports from bump/nightly-2024-05-20 #13072

Closed
wants to merge 2 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented May 21, 2024


Open in Gitpod

@@ -125,7 +125,7 @@ theorem genericPoint_eq_bot_of_affine (R : CommRingCat) [IsDomain R] :

instance functionField_isFractionRing_of_affine (R : CommRingCat.{u}) [IsDomain R] :
IsFractionRing R (Scheme.Spec.obj <| op R).functionField := by
convert StructureSheaf.IsLocalization.to_stalk R (genericPoint _)
convert StructureSheaf.IsLocalization.to_stalk R (genericPoint (Scheme.Spec.obj (op R)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nightly-2024-05-19 and onwards need a bit more of a hint here, after the bugfix in leanprover/lean4#4206

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 21, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 21, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: backports from bump/nightly-2024-05-20 [Merged by Bors] - chore: backports from bump/nightly-2024-05-20 May 21, 2024
@mathlib-bors mathlib-bors bot closed this May 21, 2024
@mathlib-bors mathlib-bors bot deleted the backports_2024-05-20 branch May 21, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants