chore: fixes for simp refactor
#571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@semorrison I think this needs a different base branch, and/or a lean-pr-releases branch |
|
I've changed the base to |
kim-em
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM. Once leanprover/lean4#3210 lands in a nightly, we can update this PR and then merge into bump/v4.6.0.
kim-em
added
awaiting-review
digama0
reviewed
Feb 1, 2024
digama0
approved these changes
Feb 1, 2024
digama0
reviewed
Feb 1, 2024
Co-authored-by: Mario Carneiro <[email protected]>
kim-em
added a commit
that referenced
this pull request
Feb 1, 2024
* feat: hover info for `rcases h : ...` (#486) * feat: hover info for `rcases h : ...` * fix * chore: adaptations for leanprover/lean4#3123 (#502) * chore: adaptations for leanprover/lean4#3123 * update toolchain * chore: remove unnecessary `have` (#516) After leanprover/lean4#3132 the linter will complain about this. * chore: simproc PR changes (#496) See leanprover/lean4#3124 Co-authored-by: Scott Morrison <[email protected]> * chore: adaptions for nightly-2023-01-11 (#524) * advance toolchain to nightly-2024-01-12, no updates required * chore: updates to DiscrTree for changes in nightly (#536) * doc: extend docstrings for `ext` and `ext1` (#525) Makes sure to mention that the patterns are processed using `rintro`, and makes sure `ext` mentions `ext1`. * docs(Data/List): typo (#529) * feat: Eq.rec lemma (#385) * chore: Add empty collection instance to BinomialHeap (#532) * Incremental Library Search (#421) This ports library_search from Mathlib to Std. It preserves the ability to do caching, but is designed to support a cacheless mode. The exact and apply tactics are named `std_exact?` and `std_apply?`, but will eventually be renamed. Co-authored-by: Scott Morrison <[email protected]> * fix termination_by clauses in LazyDiscrTree fix LibrarySearch * bump toolchain --------- Co-authored-by: Kyle Miller <[email protected]> Co-authored-by: Martin Dvořák <[email protected]> Co-authored-by: François G. Dorais <[email protected]> Co-authored-by: Joe Hendrix <[email protected]> * feat: adaptations for leanprover/lean4#3159 (#557) * merge origin/main * chore: fixes for `simp` refactor (#571) * move to v4.6.0-rc1 * fix proofs --------- Co-authored-by: Mario Carneiro <[email protected]> Co-authored-by: Leonardo de Moura <[email protected]> Co-authored-by: Joachim Breitner <[email protected]> Co-authored-by: Kyle Miller <[email protected]> Co-authored-by: Martin Dvořák <[email protected]> Co-authored-by: François G. Dorais <[email protected]> Co-authored-by: Joe Hendrix <[email protected]>
fgdorais
added a commit
to fgdorais/batteries
that referenced
this pull request
Feb 18, 2024
) * feat: hover info for `rcases h : ...` (leanprover-community#486) * feat: hover info for `rcases h : ...` * fix * chore: adaptations for leanprover/lean4#3123 (leanprover-community#502) * chore: adaptations for leanprover/lean4#3123 * update toolchain * chore: remove unnecessary `have` (leanprover-community#516) After leanprover/lean4#3132 the linter will complain about this. * chore: simproc PR changes (leanprover-community#496) See leanprover/lean4#3124 Co-authored-by: Scott Morrison <[email protected]> * chore: adaptions for nightly-2023-01-11 (leanprover-community#524) * advance toolchain to nightly-2024-01-12, no updates required * chore: updates to DiscrTree for changes in nightly (leanprover-community#536) * doc: extend docstrings for `ext` and `ext1` (leanprover-community#525) Makes sure to mention that the patterns are processed using `rintro`, and makes sure `ext` mentions `ext1`. * docs(Data/List): typo (leanprover-community#529) * feat: Eq.rec lemma (leanprover-community#385) * chore: Add empty collection instance to BinomialHeap (leanprover-community#532) * Incremental Library Search (leanprover-community#421) This ports library_search from Mathlib to Std. It preserves the ability to do caching, but is designed to support a cacheless mode. The exact and apply tactics are named `std_exact?` and `std_apply?`, but will eventually be renamed. Co-authored-by: Scott Morrison <[email protected]> * fix termination_by clauses in LazyDiscrTree fix LibrarySearch * bump toolchain --------- Co-authored-by: Kyle Miller <[email protected]> Co-authored-by: Martin Dvořák <[email protected]> Co-authored-by: François G. Dorais <[email protected]> Co-authored-by: Joe Hendrix <[email protected]> * feat: adaptations for leanprover/lean4#3159 (leanprover-community#557) * merge origin/main * chore: fixes for `simp` refactor (leanprover-community#571) * move to v4.6.0-rc1 * fix proofs --------- Co-authored-by: Mario Carneiro <[email protected]> Co-authored-by: Leonardo de Moura <[email protected]> Co-authored-by: Joachim Breitner <[email protected]> Co-authored-by: Kyle Miller <[email protected]> Co-authored-by: Martin Dvořák <[email protected]> Co-authored-by: François G. Dorais <[email protected]> Co-authored-by: Joe Hendrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues created by leanprover/lean4#3210