Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upstream split_ifs #243

Closed
wants to merge 3 commits into from
Closed

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 6, 2023

No description provided.

@kim-em kim-em added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Sep 6, 2023
@kim-em kim-em mentioned this pull request Oct 15, 2023
2 tasks
@digama0
Copy link
Member

digama0 commented Oct 15, 2023

This one seems like big sadness to me, why can't we use split instead? Have we given up on progressing leanprover/lean4#2414 or is the issue something else?

@kim-em
Copy link
Collaborator Author

kim-em commented Oct 16, 2023

@digama0 my main complaint is lack of split with h.

@digama0
Copy link
Member

digama0 commented Oct 16, 2023

Is that a feature request I hear?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 19, 2023
@kim-em
Copy link
Collaborator Author

kim-em commented Oct 24, 2023

I'm going to close this now, let's see if we can work on split instead.

@kim-em kim-em closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants