chore(Logic): give implicit argument an accessible name #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 15, 2025
|
Mathlib CI status (docs):
|
fgdorais
approved these changes
Feb 15, 2025
Merged
via the queue into
leanprover-community:main
with commit Feb 15, 2025
80520e5
3 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Sort uargument toheq_iff_eqhas nameα✝, making it inaccessible using(_ := _)syntax. As such, the change here refers toαby name so that it has nameαinstead.Note that this PR does not change the implicitness of any of the variables.
This is the smallest change I could think of which would have the desired effect (making the type argument accessible) and change nothing else, but if there is a preferred alternate option, I am happy to go with that instead.