Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #50

Merged
merged 1 commit into from
Dec 20, 2021
Merged

fix: typo #50

merged 1 commit into from
Dec 20, 2021

Conversation

weakish
Copy link
Contributor

@weakish weakish commented Dec 15, 2021

Thank 沉寂 for bringing this to our attention.

@weakish
fix: typo
d4ac444 
Thank 沉寂 for bringing this to our attention.
@weakish weakish requested a review from jysperm December 15, 2021 10:36
jysperm
jysperm approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@jysperm jysperm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会影响对外的 API，不过还是把 typo 改成比较重要。

@weakish
Copy link
Contributor Author

weakish commented Dec 20, 2021

是的，这是一个 breaking change（不过反正版本号还小于 1

@weakish weakish merged commit 7d89f2f into master Dec 20, 2021
@weakish weakish deleted the metadata-typo branch December 20, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jysperm jysperm jysperm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weakish @jysperm