-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI: Bump jobs to Ubuntu 24 #4787
Conversation
FYI @liushuyu. Looking pretty good, just some sanitizer problems with the distro sanitizer libs, the buggy ldc/tests/debuginfo/print_gdb.d Line 100 in 40716be
|
This is due to Docker blocking the ASLR disable request (because it's a security risk). See moby/moby#43011. The temporary workaround is to disable the container security features (or enable
This works. I don't know if this should be the correct behaviour, though. |
91a2662
to
165bc17
Compare
Which hopefully fixes the ASLR issue for the sanitizer lit-tests.
165bc17
to
1dd76cc
Compare
I think I will still open a bug report for GDB, as LLDB (which does not have D support) can resolve this symbol without the namespace:
(Although it might look like LLDB did not correctly handle module declaration) |
Congratulations on making the scripts run on someone else's computer (aka CI)! I think you can just cherry-pick 8387651 to make the remainder of the CI tests pass. |
Thanks, that'd be awesome. As it worked with gdb 9 too, I'm pretty sure it should work without fully qualified name.
Heh thanks, your pointers were very helpful.
[I don't see the Circle failures in your LLVM-19 PR as a blocker for merging, nor the xtensa failure here as a blocker for this PR, Both PRs are ready and should land very soon, just giving Nicholas some time to reply wrt. the SPIR-V target layout.] I didn't want to cherry-pick the xtensa fix with other unrelated changes, nor apply your fix manually and potentially cause merge conflicts then for you. |
For posterity: container and VM performances seem more or less identical, and the credit consumption is identical too. The only real downside of the VM is the startup time, something like 30-60 seconds. |
@kinke I have opened a bug report on the upstream and a suggested fix: https://sourceware.org/bugzilla/show_bug.cgi?id=32398. I can add your email address (as seen from GitHub) to the cc list if you want (so that you can test the fix upstream provided); I know some companies have specific rules when using the company email, so I won't do it without asking. |
Oh wow, so you did basically everything already! :) Thanks! - I fully trust your detailed report to be enough for the gdb team to come up with a regression test case; I don't build gcc myself or use experimental toolchains, so please leave me out, I won't be able to early-test. But please link your report in #4389, which we'll be able to close once the gdb fix has landed and we can confirm it via CI. It's not an LDC issue per se as you know, just a place where this testsuite-problem is tracked, and remains open, whereas this PR is merged, closed and forgotten. :) |
Thanks! Will do. |
No description provided.