Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus CI: Get FreeBSD working again after their LLVM 9 => 15 bump #4373

Merged
merged 9 commits into from
May 4, 2023
Merged

Cirrus CI: Get FreeBSD working again after their LLVM 9 => 15 bump #4373

merged 9 commits into from
May 4, 2023

Conversation

kinke
Copy link
Member

@kinke kinke commented Apr 15, 2023

No description provided.

@kinke
Copy link
Member Author

kinke commented Apr 15, 2023 •
edited
Loading

According to https://ports.freebsd.org/cgi/ports.cgi?query=llvm&stype=name&sektion=all, they really bumped the default LLVM version from 9 to 15, and dropped the llvm90 package at the same time (only v10+ available). All our existing FreeBSD packages depend on the old LLVM 9 (need one as host compiler). WTF guys.

@kinke kinke marked this pull request as draft April 15, 2023 16:02
@kinke
Copy link
Member Author

kinke commented Apr 20, 2023

Thx Johan for the help! I sure as hell didn't expect their ldc package to be at v1.32.0 (!), thought it'd be some ancient version. Seems like their package versions are everything but stable (FreeBSD 12 is quite old by now)...

Anyway, just 2 lit-test failures wrt. gdb: debuginfo/{classtypes,print}_gdb.d

@JohanEngelen
Copy link
Member

I don't know about the gdb failures... could it be due to GDB version? Otherwise let's merge this one? (mark lit tests as XFAIL: FreeBSD)

@kinke
Copy link
Member Author

kinke commented Apr 25, 2023

Looks like they bumped gdb from v8 to v13 (!), so yeah, we're probably seeing the same gdb v10+ regressions as on Linux.

Our CMake script only outputs the gdb version on Linux, not on other ELF platforms; the gdb dmd-testsuite tests are disabled for the same CMake limitation, so we're only seeing the few gdb lit-tests fail.

So if we cannot downgrade the gdb package, we'll have to disable the failing gdb tests somehow for now - ideally depending on the gdb version.

@kinke kinke mentioned this pull request Apr 29, 2023
Merged
@JohanEngelen JohanEngelen mentioned this pull request May 2, 2023
Open
@JohanEngelen
Copy link
Member

JohanEngelen commented May 2, 2023 •
edited
Loading

I took the liberty of "fixing" this with the least amount of effort by marking the tests XFAIL on FreeBSD.

Added an issue for it : #4389

@JohanEngelen
Copy link
Member

Why is the FreeBSD 12.2 stuck? (some github bug?)

@kinke
Copy link
Member Author

kinke commented May 3, 2023 •
edited
Loading

Why is the FreeBSD 12.2 stuck? (some github bug?)

Nope, it's just an orphaned required CI check in the GitHub settings, they are based on the CI job names. So after merging this, the required FreeBSD check needs to be removed, and the new 12.4 one added instead. Edit: https://github.com/ldc-developers/ldc/settings/branch_protection_rules/18913968 (branch protection rules -> required status checks)

@JohanEngelen
Copy link
Member

Let's merge this?

@kinke kinke marked this pull request as ready for review May 4, 2023 12:10
@kinke kinke merged commit d4727bd into ldc-developers:master May 4, 2023
@kinke kinke deleted the ci_freebsd branch May 4, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinke @JohanEngelen