Fix symbolic pass for handling IntrinsicElementalFunction in print()
#2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shaikh-Ubaid could you please suggest some more testcases? |
from lpython import i32
def f():
a :list[i32]= [1, 2, 3, 4,]
print(a.pop(),a)
f()Can you add this exact test case? |
|
Please mark as "Ready for review" when ready. |
|
@Shaikh-Ubaid could you please look into the reason for the failing checks? They seem unrelated to the PR. |
kmr-srbh
force-pushed
the
fix-symblic-pass-for-printing-intrinsic-elemental-function
branch
from
658e561 to
e38ee36
Compare
Shaikh-Ubaid
approved these changes
Apr 27, 2024
Shaikh-Ubaid
force-pushed
the
fix-symblic-pass-for-printing-intrinsic-elemental-function
branch
from
d322154 to
1e15742
Compare
assem2002
pushed a commit
to assem2002/lpython
that referenced
this pull request
Apr 28, 2024
…()` (lcompilers#2665) * Fix symbolic pass for handling `IntrinsicElementalFunction` in `print()` * Tests: Add tests and update references * Fix mistakenly commented out lines * Tests: Add testcase and update references * Tests: Update references * Style changes * Remove C backend * Tests: Add asserts and update test reference
assem2002
pushed a commit
to assem2002/lpython
that referenced
this pull request
Apr 28, 2024
…()` (lcompilers#2665) * Fix symbolic pass for handling `IntrinsicElementalFunction` in `print()` * Tests: Add tests and update references * Fix mistakenly commented out lines * Tests: Add testcase and update references * Tests: Update references * Style changes * Remove C backend * Tests: Add asserts and update test reference
kmr-srbh
deleted the
fix-symblic-pass-for-printing-intrinsic-elemental-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2457