-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for item access from Const
data-structures
#2579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add test to intregration_tests and register in CMakeLists
Please mark this PR ready for review once it is ready. |
Co-authored-by: Thirumalai Shaktivel <[email protected]>
Co-authored-by: Thirumalai Shaktivel <[email protected]>
@Shaikh-Ubaid @Thirumalai-Shaktivel there is a considerable degree of redundancy here, like for dictionary and lists. I have to implement slicing on |
What is the status of this PR? The CI seems to fail, please mark this PR ready for review once it is ready. |
@Thirumalai-Shaktivel this PR is ready. The only blocker is the issue stated here - #2567 (comment). Could you please look into it? |
@Shaikh-Ubaid , |
Simply remove the call to |
Const
Const
data-structures
@Shaikh-Ubaid as the A related issue is the failing slicing on |
Co-authored-by: Shaikh Ubaid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmr-srbh For this PR, you can simply add an integration test that verifies that const
list
and dict
and operation on them are supported by lpython
. And it will be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minimal changes that just do the task. Thanks for this.
Fixes #2578
The following changes were made:
dict
andlist
. Return the corresponding value.Const
is not required.Fix
Dictionary
List
Tuple
String