Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key: require non-empty-string for factory methods too #836

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Key: require non-empty-string for factory methods too #836

merged 3 commits into from
Apr 10, 2022

Conversation

Slamdunk
Copy link
Collaborator

@Slamdunk Slamdunk commented Apr 8, 2022

@Slamdunk Slamdunk requested a review from lcobucci April 8, 2022 07:24
@lcobucci lcobucci merged commit 00c96d7 into lcobucci:4.2.x Apr 10, 2022
@lcobucci lcobucci added this to the 4.2.0 milestone Apr 10, 2022
@Slamdunk Slamdunk deleted the extend_phpdoc_for_empty_keys branch April 10, 2022 12:43
@Slamdunk Slamdunk mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcobucci lcobucci lcobucci approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Slamdunk @lcobucci