Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 5.5 compatibility #257

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Fix PHP 5.5 compatibility #257

merged 1 commit into from
Aug 3, 2018

Conversation

lcobucci
Copy link
Owner

@lcobucci lcobucci commented Aug 2, 2018

As reported by @taasan in #256 we made the library incompatible with the supported PHP versions, this fixes it.

@lcobucci lcobucci added the Bug label Aug 2, 2018
@lcobucci lcobucci added this to the 3.2.4 milestone Aug 2, 2018
@lcobucci lcobucci self-assigned this Aug 2, 2018
@lcobucci
Copy link
Owner Author

lcobucci commented Aug 2, 2018

@taasan can you please check if this works for you (it should be fine), I'll tag as soon as I get your ✔️

Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@taasan
Copy link

taasan commented Aug 3, 2018

LGTM 👍

@lcobucci lcobucci merged commit c9704b7 into 3.2 Aug 3, 2018
@lcobucci lcobucci deleted the fix-php-55-compatibility branch August 3, 2018 11:23
@lcobucci
Copy link
Owner Author

lcobucci commented Aug 3, 2018

I'll release it tomorrow at night when I come back home.

@lcobucci
Copy link
Owner Author

lcobucci commented Aug 6, 2018

@taasan 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants