Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer PHP versions (allowing some to fail) #250

Merged
merged 1 commit into from
Jul 29, 2018

Conversation

lcobucci
Copy link
Owner

No description provided.

@lcobucci lcobucci added this to the 3.2.3 milestone Jul 15, 2018
@lcobucci lcobucci self-assigned this Jul 15, 2018
.travis.yml Outdated
- hhvm
- hhvm-nightly

matrix:
allow_failures:
- php: 7.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one really shouldn't be allowed to fail

Copy link
Owner Author

@lcobucci lcobucci Jul 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius 3.2 doesn't fully support PHP >= 7.1 (due to the mdanter/ecc at least the version we now use)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to solve that in 3.3 (which won't take long)

@lcobucci lcobucci force-pushed the modify-supported-versions branch from cce3247 to 117ed47 Compare July 16, 2018 19:50
@lcobucci lcobucci merged commit ac083fa into 3.2 Jul 29, 2018
@lcobucci lcobucci deleted the modify-supported-versions branch July 29, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants