Fixed hmac::verify #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lcobucci what do you think? |
|
Sorry @ptrofimov by the delay of the response and thanks for the collaboration. |
|
Great! Thanks. |
|
But could you, please, make a tag 2.1.2 for 2.1.* branch with this fix too? Because it will require time to change our project code for 3.* version. |
|
Ok, I'll create that tag. On PR #16 @henriquemoody, @ppetermann and me discussed a little bit about maintaining older releases and the decision was to update only the last version, maybe we can review that with some new ideas. |
|
Done ;) |
|
Super! Works. Thank you. |
|
@lcobucci, perhaps you should create branches only for MAJOR versions, not for MINOR ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$expected could be not a string (namely false), when function base64_decode finds in the string invalid chars. In this case, function hash_equals triggers warning "hash_equals(): Expected known_string to be a string, boolean given".
This fix solves the problem.