Add ? to resourceQuery for Consistency with interpolateName Behavior

[oe]

This PR introduces a modification to the resourceQuery behavior by adding support for ?, ensuring consistency with the behavior outlined in webpack/loader-utils#interpolateName.

Additionally, this PR resolves a specific issue related to optional query parameters in include matching rules.

Details:

1. Feature Addition:

   • Added support for ? in resourceQuery.
   • Aligns resourceQuery handling with the behavior of the interpolateName function, improving predictability and usability for developers.

2. Issue Fix:

   • Fixed an issue where optional query parameters in include rules caused incorrect file name generation.
     • For example, when using an include rule like /\.png(\?.+)?/ and name value [name].[ext]?[query]:
       • A file reference like "xxx.png" previously generated an invalid file name: xxx.png?.
       • After this PR, modifying name to [name].[ext][query] resolves the issue and produces the correct output.

Breaking Changes:

This PR introduces a non-backward-compatible change by no longer supporting configurations relying on the previously incorrect file name generation (xxx.png?). Users with such configurations will need to update their name value to [name].[ext][query].

Motivation:

Ensuring consistency across related functionalities and resolving file name generation issues enhances the developer experience and eliminates potential confusion.

[oe]

Another commit has been submitted

Fix Data Corruption Issue for Binary Resources

Details:

1. Bug Fix:

   • Fixed an issue where binary data was mishandled, leading to corrupted output files.
   • This problem primarily affects the processing of image files, although it may impact other binary resources as well.

2. Example Update:

   • Updated the example code to include a test case for verifying the handling of binary files.
   • To reproduce the original issue for testing purposes, revert the changes made to the file src/index.ts at line 84.

Steps to Verify the Fix:

1. Restore the previous code at src/index.ts:84 to reproduce the binary corruption issue.
2. Use the updated example to test the fix by processing binary resources like images.
3. Confirm that the output files are no longer corrupted and function as expected.

Motivation:

Ensuring correct handling of binary data is critical for the plugin's reliability, particularly for workflows involving binary resources such as images.

[coder-layne]

LGTM

[coder-layne]

@oe Thanks for your awesome contribution! Can you use Volta to lock the toolchain version to avoid CI check failures?

[oe]

just locked pnpm version to 9.10.0 via volta

[coder-layne]

@oe Thank you so much! I'll merge the PR and release version v1.0.0 to prevent automatic upgrades to breaking changes.

[oe]

Awesome!
The recent CI build error occurred because packageManager was not updated. A quick read through the ni source code revealed that packageManager is used instead of Volta. Maintaining the same information in two places can easily lead to errors :(

[coder-layne]

@oe I totally agree with you, but during local testing, I noticed that ni doesn't follow the version configured in the packageManager field. We could consider using Volta in CI to lock the toolchain version in the future.