-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combining publicUrl with asset path gives incorrent URL #20
Comments
akim-bow
changed the title
Combining publicUrl with asset path gives you incorrent URL
Combining publicUrl with asset path gives incorrent URL
Aug 23, 2023
Tested on 0.5.1.
Not a good idea to use path.join for url's |
coder-layne
added a commit
that referenced
this issue
Aug 23, 2023
coder-layne
added a commit
that referenced
this issue
Aug 23, 2023
Thank you for your feedback. You're correct, I'll address this in v0.5.2. |
I just released v0.5.2. You can try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This setup
And import
import wasmDep from './assets/dep.wasm'
Gives you
const wasmDep = 'https:/unpkg.com/assets/dep.wasm'
Which is incorrect URL and will work unexpectedly at runtime.
The text was updated successfully, but these errors were encountered: