fix(textinput): Account for float dimensions when showing scroller (m…

…icrosoft#2341) * Account for float dimensions when showing scroller * Use fabs() --------- Co-authored-by: Saad Najmi <[email protected]>
lawrencewin · Jan 22, 2025 · 8dd1783 · 8dd1783
1 parent 45067e3
commit 8dd1783
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/react-native/Libraries/Text/TextInput/Multiline/RCTMultilineTextInputView.mm b/packages/react-native/Libraries/Text/TextInput/Multiline/RCTMultilineTextInputView.mm
@@ -134,7 +134,9 @@ - (BOOL)shouldShowVerticalScrollbar
   CGSize textViewSize = [_backedTextInputView intrinsicContentSize];
   NSClipView *clipView = (NSClipView *)_scrollView.contentView;
   if (textViewSize.height > clipView.bounds.size.height) {
-    return YES;
+    // Sometimes dimensions returned are in floating point numbers. 
+    // If the floats are close enough, then don't show the scrollbar even if there is a fraction of overflow with the text.
+    return fabs(textViewSize.height - clipView.bounds.size.height) >= 1;
   };
 
   return NO;