Fixed possible division by zero error #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for some reason the timestamp delta is zero, presumably because the check has been called twice at the exact same time, various rate calculations caused a division by zero error. We now check for zero in delta_timestamp and assume a rate of 0 for the corresponding rate as a zero delta_timestamp implies no time has passed so the value for which the rate per time is being calculated could not have changed either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason the timestamp delta is zero, presumably because the
check has been called twice at the exact same time, various rate
calculations cause a division by zero error.
We now check for zero in delta_timestamp and assume a rate of 0 for the
corresponding rate as a zero delta_timestamp implies no time has passed
so the value for which the rate per time is being calculated could not
have changed either.
This might partly fix #17 although there are more ratios, that don't divide by delta_timestamp but some other value.