This repository has been archived by the owner on May 30, 2024. It is now read-only.
Clarified singleton nature of the LDClient #172
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
I have added test coverage for new or changed functionalityI have validated my changes against all supported platform versionsI'm marking the tasks here N/A as I only added documentation comments. This PR includes no behavior changes.
Describe the solution you've provided
Typescript engineers who rely primarily on the exported type definitions might miss that the LDClient should only be initialized as a singleton. This PR clarifies that in the inline documentation.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Missing this detail, a recent implementation initialized the LDClient on each request.