This repository has been archived by the owner on May 30, 2024. It is now read-only.
Allow existing redis client to be passed into redis_feature_store #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the redis_feature_store instantiates and manages a new connection to redis. Many services that use redis already may opt to just reuse an existing connection using their desired client. This configuration allows for use of ioredis.
|
@eli-darkly I went with the easy approach and just allowed an existing client to be passed in. I didn't end up implementing the locking mechanism, but something you guys should think of for all your clients... especially your redis clients. I was originally looking to add redlock to this, but the changes seemed out of scope for this particular PR. |
eli-darkly
added a commit
that referenced
this pull request
Apr 2, 2019
move audit step to separate job
|
Sorry this fell through the cracks. It looks fine, but I'm holding off on merging it until after a patch release that's currently in the works, since this would be a minor version bump. |
eli-darkly
approved these changes
Oct 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the redis_feature_store instantiates and manages a new
connection to redis. Many services that use redis already may opt to
just reuse an existing connection using their desired client. This
configuration allows for use of ioredis.
Related to #122