ensure the default config does not share the featureStore

configuration.js

@@ -4,23 +4,25 @@ var messages = require('./messages');
 var package_json = require('./package.json');
 
 module.exports = (function() {
-  var defaults = {
-    baseUri: 'https://app.launchdarkly.com',
-    streamUri: 'https://stream.launchdarkly.com',
-    eventsUri: 'https://events.launchdarkly.com',
-    stream: true,
-    sendEvents: true,
-    timeout: 5,
-    capacity: 1000,
-    flushInterval: 5,
-    pollInterval: 30,
-    offline: false,
-    useLdd: false,
-    allAttributesPrivate: false,
-    privateAttributeNames: [],
-    userKeysCapacity: 1000,
-    userKeysFlushInterval: 300,
-    featureStore: InMemoryFeatureStore()
+  var defaults = function() {
+    return {
+      baseUri: 'https://app.launchdarkly.com',
+      streamUri: 'https://stream.launchdarkly.com',
+      eventsUri: 'https://events.launchdarkly.com',
+      stream: true,
+      sendEvents: true,
+      timeout: 5,
+      capacity: 1000,
+      flushInterval: 5,
+      pollInterval: 30,
+      offline: false,
+      useLdd: false,
+      allAttributesPrivate: false,
+      privateAttributeNames: [],
+      userKeysCapacity: 1000,
+      userKeysFlushInterval: 300,
+      featureStore: InMemoryFeatureStore()
+    };
   };
 
   var deprecatedOptions = {
@@ -87,7 +89,7 @@ module.exports = (function() {
 
     checkDeprecatedOptions(config);
 
-    config = applyDefaults(config, defaults);
+    config = applyDefaults(config, defaults());
 
     config.baseUri = canonicalizeUri(config.baseUri);
     config.streamUri = canonicalizeUri(config.streamUri);

test/configuration-test.js

@@ -69,4 +69,10 @@ describe('configuration', function() {
     var config = configuration.validate({ pollInterval: 31 });
     expect(config.pollInterval).toEqual(31);
   });
+
+  it('should not share the default featureStore across different config instances', function() {
+    var config1 = configuration.validate({});
+    var config2 = configuration.validate({});
+    expect(config1.featureStore).not.toEqual(config2.featureStore);
+  });
 });