Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Typescript definition for method all of LDFeatureStore is incorrect #77

Closed
magne4000 opened this issue Jan 26, 2018 · 2 comments
Closed

Comments

@magne4000
Copy link

The definition

https://github.com/launchdarkly/node-client/blob/master/index.d.ts#L271

all: (callback: (err: any, res: LDFlagSet) => void) => void;

The usage

https://github.com/launchdarkly/node-client/blob/master/index.js#L211

config.feature_store.all(function(flags) {
  ...
});

fix

So the TS definition should be something like:

all: (callback: (res: LDFlagSet) => void) => void;
@magne4000 magne4000 changed the title Typescript definition for all method of LDFeatureStore is incorrect Typescript definition for method all of LDFeatureStore is incorrect Jan 26, 2018
@apucacao
Copy link
Contributor

Thanks for reporting this @magne4000 — we'll get a fix out shortly.

@apucacao
Copy link
Contributor

Hi @magne4000 , we just released 3.3.2 which includes your correction. Thanks!

eli-darkly added a commit that referenced this issue May 10, 2018
…pendency

fix transitive dependency on buggy version of "hoek"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants