Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Does your eventsource library override the native node version? #262

Closed
xtianus79 opened this issue Oct 3, 2022 · 2 comments
Closed

Does your eventsource library override the native node version? #262

xtianus79 opened this issue Oct 3, 2022 · 2 comments
Labels
Stale waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.

Comments

@xtianus79
Copy link

sorry I posted here but you can't use issues for that library that is forked.

In this article the question talks about using a body. When I read your library it seems as if I have full control over the native eventsource from node. The only option is "withcredentials". Am I thinking of this correctly?

I need to send information with my request. I'd like to do it in a post. Perhaps I am thinking of the wrong thing. Can you help explain this.

https://stackoverflow.com/questions/25099548/html-sse-request-body

@eli-darkly
Copy link
Contributor

It's not totally clear to me what you're asking, so, a couple of clarifications:

  1. The library you're talking about is https://github.com/launchdarkly/js-eventsource ... right?
  2. When you say "full control over the native eventsource from Node", what do you mean by "the native eventsource"? The main reason that this library exists (which is the same reason that the original project we forked it from exists) is that there is no SSE/EventSource implementation built into Node. There is a native EventSource API in web browsers.
  3. Did you read the README.md file? There's some fairly detailed documentation in it, including this section which is specifically about configuring it to do a POST request.

LaunchDarklyReleaseBot pushed a commit that referenced this issue Dec 7, 2022
use newer js-test-helpers for async tests
@kinyoklion kinyoklion added the waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness. label Jun 29, 2023
@github-actions
Copy link

This issue is marked as stale because it has been open for 30 days without activity. Remove the stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants