Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

deprecated crypto package #173

Closed
pouyahbb opened this issue Feb 12, 2020 · 3 comments
Closed

deprecated crypto package #173

pouyahbb opened this issue Feb 12, 2020 · 3 comments

Comments

@pouyahbb
Copy link

No description provided.

@eli-darkly
Copy link
Contributor

eli-darkly commented Feb 12, 2020 •
edited
Loading

Since this issue has no description, I'm not sure if you're referring to the node-sha1 package specifically, or the fact that we're using SHA1 at all. To be clear, we do not use SHA1 for authentication at all— just to generate a well-distributed set of large integers for computing percentage rollouts of users.

We have been using a pretty old version of node-sha1 to do this, but since that package is really just a simple wrapper for Node's crypto, we can probably just drop that dependency rather than upgrading it. But we do need to continue using the SHA1 algorithm so customers will not suddenly start seeing different results for percentage rollouts.

@eli-darkly
Copy link
Contributor

(Tracked internally as 65523)

@LaunchDarklyCI LaunchDarklyCI mentioned this issue Feb 12, 2020
Merged
@eli-darkly
Copy link
Contributor

Removed node-sha1 in the 5.11.0 release.

LaunchDarklyCI pushed a commit that referenced this issue Feb 14, 2020
@eli-darkly
Merge pull request #173 from launchdarkly/eb/ch65817/diagnostic-expli…
0387358 
…cit-false

don't omit streamInits.failed when it's false
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eli-darkly @pouyahbb