Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Error message when calling all_flags() without a user is misleading #102

Closed
jbatchelor-atlassian opened this issue Jul 1, 2018 · 1 comment
Closed

Error message when calling all_flags() without a user is misleading #102

jbatchelor-atlassian opened this issue Jul 1, 2018 · 1 comment

Comments

@jbatchelor-atlassian
Copy link
Contributor

Very minor but could save someone else some time in the future if fixed.

When calling all_flags() without a user object the log message is all_flags() called in offline mode. Returning empty map.

I don't think it'd be controversial to split the offline and user checks into to error messages.
@jbatchelor-atlassian jbatchelor-atlassian mentioned this issue Jul 2, 2018
Merged
@eli-darkly
Copy link
Contributor

Thanks for spotting this and submitting a PR. The fix will go out in the next release.

eli-darkly added a commit that referenced this issue Oct 8, 2018
@eli-darkly
Merge pull request #102 from launchdarkly/eb/ch24449/less-metadata
47524ae 
add option to reduce front-end metadata for untracked flags
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbatchelor-atlassian @eli-darkly