Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Commit

Permalink
prepare 5.3.1 release (#115)
Browse files Browse the repository at this point in the history
  • Loading branch information
eli-darkly authored Aug 27, 2018
1 parent 62903ce commit 9085265
Show file tree
Hide file tree
Showing 5 changed files with 125 additions and 102 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the LaunchDarkly Node.js SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).

## [5.3.1] - 2018-08-27
### Fixed:
- Calling `allFlagsState()` did not work if you omitted the optional second parameter, `options`, but did provide a `callback`. ([#114](https://github.com/launchdarkly/node-client/issues/114))

## [5.3.0] - 2018-08-27
### Added:
- The new `LDClient` method `allFlagsState()` should be used instead of `allFlags()` if you are passing flag data to the front end for use with the JavaScript SDK. It preserves some flag metadata that the front end requires in order to send analytics events correctly. Versions 2.5.0 and above of the JavaScript SDK are able to use this metadata, but the output of `allFlagsState()` will still work with older versions.
Expand Down
7 changes: 6 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,12 @@ var newClient = function(sdkKey, config) {
}

client.allFlagsState = function(user, options, callback) {
options = options || {};
if (callback === undefined && typeof(options) === 'function') {
callback = options;
options = {};
} else {
options = options || {};
}
return wrapPromiseCallback(new Promise(function(resolve, reject) {
sanitizeUser(user);

Expand Down
Loading

0 comments on commit 9085265

Please sign in to comment.