Merge pull request #91 from launchdarkly/eb/wait-for-init-value

fix waitForInitialization to always resolve with a value
launchdarkly · Aug 1, 2018 · 44f2d4a · 44f2d4a
2 parents bcb4f0e + 018c6f2
commit 44f2d4a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -144,7 +144,7 @@ var newClient = function(sdkKey, config) {
     }
 
     return new Promise(function(resolve, reject) {
-      client.once('ready', resolve);
+      client.once('ready', function() { resolve(client) });
       client.once('failed', reject);
     });
   };

diff --git a/test/LDClient-test.js b/test/LDClient-test.js
@@ -325,6 +325,7 @@ describe('LDClient', function() {
       client.waitForInitialization().then(callback)
         .then(() => {
           expect(callback).toHaveBeenCalled();
+          expect(callback.mock.calls[0][0]).toBe(client);
           done();
         }).catch(done.error)
     });
@@ -338,6 +339,7 @@ describe('LDClient', function() {
           client.waitForInitialization().then(callback)
             .then(() => {
               expect(callback).toHaveBeenCalled();
+              expect(callback.mock.calls[0][0]).toBe(client);
               done();
             }).catch(done.error)
         }).catch(done.error)