Allow clippy::suspicious_else_formatting when expanding query arguments. #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanding several query arguments in the query! macro creates several if false { ... } statements, which in turn trigger clippy's suspicious_else_formatting (https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting).
This commit allows the clippy lint so users won't be disturbed by it.
|
There's a few other annoying lints from clippy on the generated code. Perhaps we should just wrap all generated code in |
|
I'm pretty new to the codebase, but it seems to be the right spot to add Please let me know if it isn't the case :) |
|
Nice, been running into this as well. This should really be fixed in clippy (rust-lang/rust-clippy#6249), but disabling clippy for all macro-generated code probably is fine too. |
abonander
requested changes
Nov 17, 2020
|
I think we got rate limited ^^' |
abonander
requested changes
Nov 17, 2020
abonander
requested changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding several query arguments in the query! macro creates several
if false { ... }statements, which in turn trigger clippy's suspicious_else_formatting.This commit allows the clippy lint so users won't be disturbed by it anymore.