Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing don't parse all attributes as Meta #791

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Fixing don't parse all attributes as Meta #791

merged 1 commit into from
Nov 5, 2020

Conversation

dragonnn
Copy link
Contributor

@dragonnn dragonnn commented Nov 4, 2020

This fixes #774
Some other crates use non meta attributes, this crashes FromRow and Encode derive when using on the same struct.
This patch makes sure the identifier is sqlx before passing it to parse_meta.

@abonander abonander merged commit 7726e16 into launchbadge:master Nov 5, 2020
@abonander
Copy link
Collaborator

Thanks!

@dragonnn dragonnn mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't parse all attributes as Meta
2 participants
@dragonnn @abonander