feat: support calling Postgres procedures with the macros #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
main
branch
2 times, most recently
from
6cf15b0 to
eade49c
Compare
|
@bgeron the code for the Postgres driver was moved to the |
|
Sure thing, I merged. Actually the merge went through without conflicts (and successful rename) so I don't know what GitHub was on about 🤔 If you want me to squash (/real rebase) instead of a merge, just shoot me a message, or feel free to do it yourself. |
|
CI doesn't want to run on this branch for whatever reason. Can you try actually rebasing instead of just merging |
Fixes launchbadge#1449 (I think). I verified that the code fixes the new test. I used INOUT in setup.sql because older versions of Postgres don't support OUT parameters.
bgeron
force-pushed
the
pg-call-procedure
branch
from
00bab95 to
6ee25d6
Compare
|
Sure thing, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1449 (I think). I verified that without the fix, an appropriate invocation to
cargo testfails, and with the fix included the same invocation tocargo testpasses.I used INOUT in setup.sql because older versions of Postgres don't support OUT parameters.