added flag for PIPES_AS_CONCAT connection setting #2038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Aug 10, 2022
sqlx-core/src/mysql/options/mod.rs
Outdated
| @@ -89,6 +90,7 @@ impl MySqlConnectOptions { | |||
| ssl_ca: None, | |||
| statement_cache_capacity: 100, | |||
| log_settings: Default::default(), | |||
| disable_pipes_as_concat: true | |||
There was a problem hiding this comment.
You've inverted the logic here, this will never send PIPES_AS_CONCAT even though that should remain the default.
The flag should just be called pipes_as_concat and include the flag if true.
It also needs a public setter so people can change it.
There was a problem hiding this comment.
Understood. Should be fixed per your suggestions.
|
@jakerieger How come this PR was closed? |
|
Dunno, it wasn't me. |
|
@marcustut Wasn't sure if I needed to open a new one to fix my original commit. Looks like I don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PlanetScale (and other) databases that throw an error when the
PIPES_AS_CONCATconnection setting is set.#2034
Added a flag to
MySqlConnectSettingsstruct that defaults to true, per request.