Nightly build began to fail on sqlx #2855

nyurik · 2023-11-05T02:58:49Z

Bug Description

Due to a recent rustc regression (rated as critical), sqlx can no longer compile on the latest nightly. This is NOT due to anything in the SQLX crate. This issue exists only to track the upstream bug, and will be closed as soon as upstream is fixed. See rust-lang/rust#117598

Minimal Reproduction

$ rustup toolchain install nightly
$ rustup update
$ cargo +nightly build

Info

SQLx version: latest git and 0.7
SQLx features enabled: default or "sqlite", "runtime-tokio"
Database server and version: n/a
Operating system: Linux Mint
rustc --version: rustc 1.75.0-nightly (4b85902b4 2023-11-04)

Error

   Compiling sqlx-core v0.7.2 (/home/nyurik/dev/rust/sqlx/sqlx-core)
warning: unused import: `WriteBuffer`
  --> sqlx-core/src/net/socket/mod.rs:10:36
   |
10 | pub use buffered::{BufferedSocket, WriteBuffer};
   |                                    ^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:32:21
    |
32  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasValueRef<'r>>::Database`
               found associated type `<any::database::Any as HasValueRef<'r>>::Database`
note: the required lifetime does not necessarily outlive the lifetime `'r` as defined here
   --> sqlx-core/src/any/database.rs:31:6
    |
31  | impl<'r> HasValueRef<'r> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:119:20
    |
119 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:32:21
    |
32  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasValueRef<'r>>::Database`
               found associated type `<any::database::Any as HasValueRef<'r>>::Database`
note: the lifetime `'r` as defined here doesn't meet the lifetime requirements
   --> sqlx-core/src/any/database.rs:31:6
    |
31  | impl<'r> HasValueRef<'r> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:119:20
    |
119 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:38:21
    |
38  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasStatement<'q>>::Database`
               found associated type `<any::database::Any as HasStatement<'q>>::Database`
note: the required lifetime does not necessarily outlive the lifetime `'q` as defined here
   --> sqlx-core/src/any/database.rs:37:6
    |
37  | impl<'q> HasStatement<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:153:20
    |
153 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:38:21
    |
38  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasStatement<'q>>::Database`
               found associated type `<any::database::Any as HasStatement<'q>>::Database`
note: the lifetime `'q` as defined here doesn't meet the lifetime requirements
   --> sqlx-core/src/any/database.rs:37:6
    |
37  | impl<'q> HasStatement<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:153:20
    |
153 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:44:21
    |
44  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasArguments<'q>>::Database`
               found associated type `<any::database::Any as HasArguments<'q>>::Database`
note: the required lifetime does not necessarily outlive the lifetime `'q` as defined here
   --> sqlx-core/src/any/database.rs:43:6
    |
43  | impl<'q> HasArguments<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:135:20
    |
135 |     type Database: Database;
    |                    ^^^^^^^^

error[E0308]: mismatched types
   --> sqlx-core/src/any/database.rs:44:21
    |
44  |     type Database = Any;
    |                     ^^^ lifetime mismatch
    |
    = note: expected associated type `<any::database::Any as HasArguments<'q>>::Database`
               found associated type `<any::database::Any as HasArguments<'q>>::Database`
note: the lifetime `'q` as defined here doesn't meet the lifetime requirements
   --> sqlx-core/src/any/database.rs:43:6
    |
43  | impl<'q> HasArguments<'q> for Any {
    |      ^^
note: the lifetime requirement is introduced here
   --> sqlx-core/src/database.rs:135:20
    |
135 |     type Database: Database;
    |                    ^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
warning: `sqlx-core` (lib) generated 1 warning (1 duplicate)
error: could not compile `sqlx-core` (lib) due to 6 previous errors; 1 warning emitted
warning: build failed, waiting for other jobs to finish...
warning: `sqlx-core` (lib) generated 1 warning
error: could not compile `sqlx-core` (lib) due to 6 previous errors; 1 warning emitted

The text was updated successfully, but these errors were encountered:

HTGAzureX1212 · 2023-11-05T03:40:17Z

Just encountered the very same error today.

nyurik · 2023-11-05T03:40:47Z

I also filed a short version of this bug at rust-lang/rust#117598

abonander · 2023-11-06T21:29:43Z

I'll leave this open for informational purposes but it sounds like it needs to be fixed upstream.

Feel free to close when that happens.

lirannl · 2023-11-07T13:10:18Z

Can confirm this also applies to rust beta (1.74) and stable (1.73), and sqlx 0.7.1 and 0.7.0, regardless of locked-ness.

rakshith-ravi · 2023-11-08T00:47:52Z

Can confirm this also applies to rust beta (1.74) and stable (1.73), and sqlx 0.7.1 and 0.7.0, regardless of locked-ness.

Stable rust seems to work fine. I haven't tested beta, but I am able to build just fine on stable

Edit: Are you sure there's no rust-toolchain.toml that's forcing nightly by any chance?

nyurik · 2023-11-08T01:11:01Z

This is not a sqlx issue, but lots of people might see this bug if they try to build their own code with the nightly toolchain due to a recent Rust regression. I updated the description to clarify that.

amiller68 · 2023-11-08T17:40:51Z

I noticed the rust-lang issue has been marked as closed, but I'm still running into this in CI. Have not tested locally, but is anyone else still struggling with this?

LeviticusNelson · 2023-11-08T18:06:56Z

@amiller68 I'm certain it's because nightly-2023-11-08 has not been released on rustup yet.

amiller68 · 2023-11-08T18:08:03Z

u right u right my bad

Cyberphinx · 2023-11-09T10:09:28Z

I'm having the same issue

Ltrlg · 2023-11-09T10:29:14Z

The nightly-2023-11-09 toolchain (with rustc 2023-11-08) is available and seems to indeed be working.

mattrighetti · 2023-11-10T13:53:48Z

rustc 1.75.0-nightly fixed the issue it seems

luke-milavec · 2023-11-14T20:17:24Z

still having issues on rustc 1.75.0-nightly

nyurik · 2023-11-15T01:47:20Z

@luke-milavec run rustup update first. Then post the result of rustc +nightly -V

Had a bunch of issues following the text - corresponding_question vs question_id in a bunch of queries - not RETURNING id, content, corresponding_question" from insert - comile errors between rust 1.73 and sqlx 0.7.4 ``` error[E0658]: `async fn` return type cannot contain a projection or `Self` that references lifetimes from a parent scope error: could not compile `sqlx-core` ``` - launchbadge/sqlx#2855 (comment) - updated with ```sh rustc --version rustc 1.73 rustup update rustc --version rustc 1.78.0 cargo --version cargo 1.78.0 ``` - but got there in the end - try: just just clean just setup-db cargo run just demo-crud

nyurik added the bug label Nov 5, 2023

nyurik mentioned this issue Nov 5, 2023

Recent nightly causes [E0308]: mismatched types rust-lang/rust#117598

Closed

photino mentioned this issue Nov 5, 2023

Fail to build the project on the nightly zino-rs/zino#58

Closed

gbj mentioned this issue Nov 5, 2023

fix: run <ErrorBoundary/> in a child so siblings don't collide (closes #1987) leptos-rs/leptos#1991

Merged

mattrighetti mentioned this issue Nov 6, 2023

feat/edit in editor mattrighetti/envelope#20

Merged

4 tasks

cpu mentioned this issue Nov 6, 2023

Small tweaks to Rust code after a review pass rustls/rustls-bench-app#5

Merged

abonander added the bug:rust Indicates a bug or regression in Rust label Nov 6, 2023

josecelano mentioned this issue Nov 7, 2023

Sqlx-core v0.7.2 doesn't compile with Rust nightly version 1.75.0 torrust/torrust-index#371

Closed

blackghost1987 mentioned this issue Nov 7, 2023

update diesel-async to 0.4.1 rwf2/Rocket#2641

Closed

abonander closed this as completed Mar 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nightly build began to fail on sqlx #2855

Nightly build began to fail on sqlx #2855

nyurik commented Nov 5, 2023 •

edited

Loading

HTGAzureX1212 commented Nov 5, 2023

nyurik commented Nov 5, 2023

abonander commented Nov 6, 2023

lirannl commented Nov 7, 2023 •

edited

Loading

rakshith-ravi commented Nov 8, 2023 •

edited

Loading

nyurik commented Nov 8, 2023

amiller68 commented Nov 8, 2023

LeviticusNelson commented Nov 8, 2023

amiller68 commented Nov 8, 2023

Cyberphinx commented Nov 9, 2023

Ltrlg commented Nov 9, 2023

mattrighetti commented Nov 10, 2023

luke-milavec commented Nov 14, 2023

nyurik commented Nov 15, 2023

Nightly build began to fail on sqlx #2855

Nightly build began to fail on sqlx #2855

Comments

nyurik commented Nov 5, 2023 • edited Loading

Bug Description

Minimal Reproduction

Info

Error

HTGAzureX1212 commented Nov 5, 2023

nyurik commented Nov 5, 2023

abonander commented Nov 6, 2023

lirannl commented Nov 7, 2023 • edited Loading

rakshith-ravi commented Nov 8, 2023 • edited Loading

nyurik commented Nov 8, 2023

amiller68 commented Nov 8, 2023

LeviticusNelson commented Nov 8, 2023

amiller68 commented Nov 8, 2023

Cyberphinx commented Nov 9, 2023

Ltrlg commented Nov 9, 2023

mattrighetti commented Nov 10, 2023

luke-milavec commented Nov 14, 2023

nyurik commented Nov 15, 2023

nyurik commented Nov 5, 2023 •

edited

Loading

lirannl commented Nov 7, 2023 •

edited

Loading

rakshith-ravi commented Nov 8, 2023 •

edited

Loading